Repository navigation
test: Deflake L0_socket reuse-port request distribution check - #9001
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
[Low impact] The PR appears safe to merge. SummaryUpdates the reuse-port check in
No actionable new issues were found. Reviews (2) · Last reviewed commit: "test: Cap L0_socket reuse-port retries a..." · Reviewed by Greptile |
A third batch makes a chance miss negligible, while a listener that never accepts still fails. Ten rounds only delays that failure. Signed-off-by: Yingge He <yinggeh@nvidia.com>
yinggeh
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
L0_socketstarts 3 servers sharing the HTTP/gRPC port (--reuse-*-port=true), sends a single batch of 11 client processes, and fails if any server'snv_inference_request_successis 0. The kernel uses a hash to pick whichSO_REUSEPORTlistener gets each new connection, so with 11 connections there's roughly a 3·(2/3)^11 ≈ 5% chance per protocol that one server gets nothing. That matches the intermittent pseudo-nightly failures: gRPC counts were 0/16/6 on 10-06 and 8/14/0 on 10-02, and the runs in between passed.Change: send batches of 11 clients until all three servers have served at least one request, up to
MAX_CLIENT_ROUNDS=3. If a server still has 0 after 3 rounds, the test fails as before. A listener that really never receives connections is still caught; only the chance-based miss goes away. The test also prints the per-round counts and waits on each client PID individually. Before,wait $pidsonly returned the exit status of the last client, so failures in other clients went unnoticed.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
None
Where should the reviewer start?
qa/L0_socket/test.sh, the reuse-port distribution loop near the end of the file.Test plan:
bash -nand pre-commit pass. I tested the loop logic locally with a fake client that assigns requests at random. I haven't run it against a real server. It needs anL0_socket--baseCI run.75864706
75864846
75865062
75865453
75867062
75890914
75890967
75891050
75891151
75891185
75891245
75891343
75891394
75891433
75892802
75892855
75893129
75893186
75893251
75893324
75893385
75893444
Caveats:
In the worst case the test takes up to 3x as many client runs. In practice it almost always stops after round 1.
Background
The pseudo-nightly CI health report flagged
L0_socket--baseas newly broken (dl/dgx/tritonserver job 473179531).Related Issues:
L0_socket--baseflake (no ticket yet)Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/42b5577b240344db884012e785abfcc6
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/42b5577b240344db884012e785abfcc6?variant=devin